Skip to content

test(RHOAIENG-26485): Add new SDK e2e tests which cover Job creation for existing cluster #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pawelpaszki
Copy link
Contributor

@pawelpaszki pawelpaszki commented Aug 25, 2025

Issue link

RHOAIENG-26485

What changes have been made

test(RHOAIENG-26485): Add new SDK e2e tests which cover Job creation for existing cluster

Verification steps

Login to ROSA cluster with RHOAI installed and run (make sure that the poetry dependencies are installed locally):

poetry run pytest tests/e2e/rayjob_existing_cluster_oauth_test.py -v -s

kind test should be picked up automatically by GH workflow (for GPU)

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link
Contributor

openshift-ci bot commented Aug 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kryanbeane for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.49%. Comparing base (5a77f7b) to head (69d1c9c).
⚠️ Report is 3 commits behind head on ray-jobs-feature.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           ray-jobs-feature     #888      +/-   ##
====================================================
- Coverage             93.65%   93.49%   -0.16%     
====================================================
  Files                    20       21       +1     
  Lines                  1717     1767      +50     
====================================================
+ Hits                   1608     1652      +44     
- Misses                  109      115       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pawelpaszki pawelpaszki deleted the RHOAIENG-26485 branch August 27, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant