Skip to content

Remove custom metrics API implementation (keep external metrics) #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
astefanutti opened this issue Aug 25, 2023 · 2 comments · Fixed by #619
Closed

Remove custom metrics API implementation (keep external metrics) #608

astefanutti opened this issue Aug 25, 2023 · 2 comments · Fixed by #619
Assignees

Comments

@astefanutti
Copy link
Contributor

WHY

The multi-cluster mode relies on serving the Kubernetes external metrics API, to provide resource allocation information on the MCAD agent cluster nodes. This is achieved by embedding and copy of the custom-metrics-apiserver, which provides a template to implement both the custom and external metrics APIs. However, the implementation of the custom metrics API is not used at all.

WHAT

Remove the custom metrics API implementation, as well as the corresponding APIService and ClusterRoleBinding resources.

TESTS

The e2e tests should pass.

@asm582
Copy link
Member

asm582 commented Aug 25, 2023

FYI, @dmatch01 the codeflare operator is disabling the above features for a single cluster install.

@asm582
Copy link
Member

asm582 commented Aug 25, 2023

Adding @metalcycling to the thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants