Generate MCAD clients using clientgen tools #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z103cb
requested review from
astefanutti,
dmatch01,
metalcycling,
anishasthana and
asm582
astefanutti
reviewed
Aug 1, 2023
|
@dmatch01, @metalcycling and @asm582 I am flipping this for ready for review. Please answer the question of removal of deprecated packages. cc: @tardieu |
Minor cleanups.
|
Great! /lgtm |
asm582
reviewed
Aug 2, 2023
pkg/client/clientset/versioned/typed/quotasubtree/v1/quotasubtree_client.go
Show resolved
Hide resolved
|
Thanks @z103cb for discussing Nits offline. /approve |
asm582
approved these changes
Aug 2, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asm582, metalcycling The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
Fixes #514
What changes have been made
Added client generation using client gen tools
Verification steps
Locally ran the end 2 end tests and unit tests
Checks