Skip to content

Move APIs to codeflare.dev groups #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 31, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -217,15 +217,15 @@ clean:
#CRD file maintenance rules
DEPLOYMENT_CRD_DIR=deployment/mcad-controller/crds
CRD_BASE_DIR=config/crd/bases
MCAD_CRDS= ${DEPLOYMENT_CRD_DIR}/ibm.com_quotasubtrees.yaml \
${DEPLOYMENT_CRD_DIR}/mcad.ibm.com_appwrappers.yaml \
${DEPLOYMENT_CRD_DIR}/mcad.ibm.com_schedulingspecs.yaml
MCAD_CRDS= ${DEPLOYMENT_CRD_DIR}/quota.codeflare.dev_quotasubtrees.yaml \
${DEPLOYMENT_CRD_DIR}/workload.codeflare.dev_appwrappers.yaml \
${DEPLOYMENT_CRD_DIR}/workload.codeflare.dev_schedulingspecs.yaml

update-deployment-crds: ${MCAD_CRDS}

${DEPLOYMENT_CRD_DIR}/ibm.com_quotasubtrees.yaml : ${CRD_BASE_DIR}/ibm.com_quotasubtrees.yaml
${DEPLOYMENT_CRD_DIR}/mcad.ibm.com_appwrappers.yaml : ${CRD_BASE_DIR}/mcad.ibm.com_appwrappers.yaml
${DEPLOYMENT_CRD_DIR}/mcad.ibm.com_schedulingspecs.yaml : ${CRD_BASE_DIR}/mcad.ibm.com_schedulingspecs.yaml
${DEPLOYMENT_CRD_DIR}/quota.codeflare.dev_quotasubtrees.yaml : ${CRD_BASE_DIR}/quota.codeflare.dev_quotasubtrees.yaml
${DEPLOYMENT_CRD_DIR}/workload.codeflare.dev_appwrappers.yaml : ${CRD_BASE_DIR}/workload.codeflare.dev_appwrappers.yaml
${DEPLOYMENT_CRD_DIR}/workload.codeflare.dev_schedulingspecs.yaml : ${CRD_BASE_DIR}/workload.codeflare.dev_schedulingspecs.yaml

$(DEPLOYMENT_CRD_DIR)/%: ${CRD_BASE_DIR}/%
cp $< $@
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.9.2
creationTimestamp: null
name: quotasubtrees.ibm.com
name: quotasubtrees.quota.codeflare.dev
spec:
group: ibm.com
group: quota.codeflare.dev
names:
kind: QuotaSubtree
listKind: QuotaSubtreeList
Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.9.2
creationTimestamp: null
name: schedulingspecs.mcad.ibm.com
name: schedulingspecs.workload.codeflare.dev
spec:
group: mcad.ibm.com
group: workload.codeflare.dev
names:
kind: SchedulingSpec
listKind: SchedulingSpecList
Expand Down
6 changes: 3 additions & 3 deletions config/crd/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

resources:
- bases/ibm.com_quotasubtrees.yaml
- bases/mcad.ibm.com_appwrappers.yaml
- bases/mcad.ibm.com_schedulingspecs.yaml
- bases/quota.codeflare.dev_quotasubtrees.yaml
- bases/workload.codeflare.dev_appwrappers.yaml
- bases/workload.codeflare.dev_schedulingspecs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.9.2
creationTimestamp: null
name: quotasubtrees.ibm.com
name: quotasubtrees.quota.codeflare.dev
spec:
group: ibm.com
group: quota.codeflare.dev
names:
kind: QuotaSubtree
listKind: QuotaSubtreeList
Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.9.2
creationTimestamp: null
name: schedulingspecs.mcad.ibm.com
name: schedulingspecs.workload.codeflare.dev
spec:
group: mcad.ibm.com
group: workload.codeflare.dev
names:
kind: SchedulingSpec
listKind: SchedulingSpecList
Expand Down
4 changes: 2 additions & 2 deletions deployment/mcad-controller/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,8 @@ metadata:
kubernetes.io/bootstrapping: rbac-defaults
rules:
- apiGroups:
- mcad.ibm.com
- ibm.com
- quota.codeflare.dev
- workload.codeflare.dev
resources:
- xqueuejobs
- queuejobs
Expand Down
2 changes: 1 addition & 1 deletion doc/usage/aw-01.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: mcad.ibm.com/v1beta1
apiVersion: workload.codeflare.dev/v1beta1
kind: AppWrapper
metadata:
name: 0001-aw-generic-deployment-1
Expand Down
2 changes: 1 addition & 1 deletion doc/usage/aw-02.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: mcad.ibm.com/v1beta1
apiVersion: workload.codeflare.dev/v1beta1
kind: AppWrapper
metadata:
name: 0002-aw-generic-deployment-2
Expand Down
2 changes: 1 addition & 1 deletion doc/usage/examples/aw-1-k8s-job1.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: mcad.ibm.com/v1beta1
apiVersion: workload.codeflare.dev/v1beta1
kind: AppWrapper
metadata:
name: aw-generic-statefulset-2
Expand Down
2 changes: 1 addition & 1 deletion doc/usage/examples/aw-1-k8s-job2.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: mcad.ibm.com/v1beta1
apiVersion: workload.codeflare.dev/v1beta1
kind: AppWrapper
metadata:
name: aw-generic-statefulset-2
Expand Down
2 changes: 1 addition & 1 deletion doc/usage/examples/aw-1-k8s-job3.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: mcad.ibm.com/v1beta1
apiVersion: workload.codeflare.dev/v1beta1
kind: AppWrapper
metadata:
name: aw-generic-statefulset-2
Expand Down
2 changes: 1 addition & 1 deletion doc/usage/examples/kuberay/config/aw-kuberay-glue.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: mcad.ibm.com/v1beta1
apiVersion: workload.codeflare.dev/v1beta1
kind: AppWrapper
metadata:
name: raycluster-glue
Expand Down
2 changes: 1 addition & 1 deletion doc/usage/examples/kuberay/config/aw-raycluster.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: mcad.ibm.com/v1beta1
apiVersion: workload.codeflare.dev/v1beta1
kind: AppWrapper
metadata:
name: raycluster-autoscaler
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ metadata:
name: system:controller:xqueuejob-controller
rules:
- apiGroups:
- mcad.ibm.com
- workload.codeflare.dev
resources:
- xqueuejobs
- queuejobs
Expand Down
6 changes: 3 additions & 3 deletions doc/usage/quota_management/quickstart.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ optimize resource utilization, avoid resource starvation, and ensure quality of
## Example QuotaSubtree

```yaml
apiVersion: ibm.com/v1
apiVersion: quota.codeflare.dev/v1
kind: QuotaSubtree
metadata:
name: context-root
Expand All @@ -37,7 +37,7 @@ spec:
cpu: 2000m
memory: 8000Mi
---
apiVersion: ibm.com/v1
apiVersion: quota.codeflare.dev/v1
kind: QuotaSubtree
metadata:
name: context-root-children
Expand All @@ -64,7 +64,7 @@ spec:
## Using quota trees in your AppWrappers

```yaml
apiVersion: mcad.ibm.com/v1beta1
apiVersion: workload.codeflare.dev/v1beta1
kind: AppWrapper
metadata:
name: myGangScheduledApp
Expand Down
6 changes: 3 additions & 3 deletions doc/usage/tutorial.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Refer to [deployment instructions](../deploy/deployment.md) on how to deploy the
After successfully deploying the __Multi-Cluster Application Dispatcher__ Controller, create an AppWrapper custom resource in a file named `aw-01.yaml` with the following content:

```yaml
apiVersion: mcad.ibm.com/v1beta1
apiVersion: workload.codeflare.dev/v1beta1
kind: AppWrapper
metadata:
name: 0001-aw-generic-deployment-1
Expand Down Expand Up @@ -202,7 +202,7 @@ The next step is to create a second `AppWrapper` job that has resource demands t
Create an `AppWrapper` job in a file named `aw-02.yaml` with the following content:

```yaml
apiVersion: mcad.ibm.com/v1beta1
apiVersion: workload.codeflare.dev/v1beta1
kind: AppWrapper
metadata:
name: 0002-aw-generic-deployment-2
Expand Down Expand Up @@ -312,7 +312,7 @@ Delete the first `AppWrapper` job.

```bash
$ kubectl delete -f aw-01.yaml
appwrapper.mcad.ibm.com "0001-aw-generic-deployment-1" deleted
appwrapper.workload.codeflare.dev "0001-aw-generic-deployment-1" deleted
```

Check the pods status of the `AppWrapper` jobs. The new pods from the second `AppWrapper` job: `0002-aw-generic-deployment-2` job should now be deployed and running.
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/controller/v1beta1/doc.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ limitations under the License.

// +k8s:deepcopy-gen=package
// +kubebuilder:object:generate=true
// +groupName=mcad.ibm.com
// +groupName=workload.codeflare.dev

package v1beta1
2 changes: 1 addition & 1 deletion pkg/apis/controller/v1beta1/register.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ var (
)

// GroupName is the group name used in this package.
const GroupName = "mcad.ibm.com"
const GroupName = "workload.codeflare.dev"

// SchemeGroupVersion is the group version used to register these objects.
var SchemeGroupVersion = schema.GroupVersion{Group: GroupName, Version: "v1beta1"}
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/quotaplugins/quotasubtree/v1/doc.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ limitations under the License.

// +k8s:deepcopy-gen=package
// +kubebuilder:object:generate=true
// +groupName=ibm.com
// +groupName=quota.codeflare.dev

package v1
2 changes: 1 addition & 1 deletion pkg/apis/quotaplugins/quotasubtree/v1/register.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ var (

const (
// GroupName is the group name used in this package.
GroupName = "ibm.com"
GroupName = "quota.codeflare.dev"

// GroupVersion is the version of scheduling group
GroupVersion = "v1"
Expand Down
36 changes: 18 additions & 18 deletions pkg/client/clientset/versioned/clientset.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions pkg/client/clientset/versioned/fake/clientset_generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions pkg/client/clientset/versioned/fake/register.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions pkg/client/clientset/versioned/scheme/register.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading