Add docs for FluentBundle #73
Conversation
|
Thank you for the docs! I'm a bit torn on whether I should merge them right now. The current state of master is very outdated, and as we get close to Fluent Syntax 1.0, I have a branch that I intend to merge soon which is a pretty major refactor of fluent-rs. I think it would make sense to land this patch into that branch or wait for it to be merged and rebase. Let me know what you think! |
Add a simple binary for testing Support menubar.ftl except of expressions Support multiline patterns Add EOF tests support Support basic JSON fixtures Support first set of comparison tests Support most of the comments Use serializer instead of deserializer Uncomment some fixture tests with slight modifications Support Junk Use ps.take_if in more places Support all reference fixtures Fix benches Support TermReference Support variants and select expression Update to rust 2018 preview 2 Use 2018 use extern macros Clean up whitespace collecting Remove try Update bench to Rust 2018 Support parsing of 0.7 reference tests Support CallExpressions
This is a massive rewrite of the whole crate. It separates out three crates: fluent-syntax becomes a zero-copy AST+parser(+serialized in the future) compabile with Fluent 0.8 fluent-bundle becomes aligned with fluent-bundle in JS fluent becomes a top-level crate with added simple ResourceManager. All of the code is compatible with current stable Rust 2018.
|
Rebasing this PR will not be trivial. Depending on the extent of changes in your branch, the docs might become obsolete. Does your branch make many changes to |
|
I'm agnostic. No hard feelings if you want to close this out. Either way I'd appreciate a ping when that new branch is ready and I'll take a crack at new docs for it if there are gaps. |
…ager via Cow" This reverts commit 6e02272.
It wouldn't unless we released @JohnHeitmann - my branch is now complete and I'll discuss with @stasm the plan to land it on Monday. If you rebase your patch against #76, I'll pull it into my branch, or we can wait for the branch to land and then land it! I hope it won't be too much work to rebase. Thanks! |
Added docs for FluentBundle. Also, corrected some errors in the pre-existing docs.
|
I just pushed my first pass at a rebase on your changes. It's Good Enough to Commit™️, but I'll probably have a polish pass or two later on. If this lingers I'll just keep updating in place. |
* Added error example to format() * Documented format_message()
|
@JohnHeitmann thanks! Can you report it as a PR against https://github.com/zbraniecki/fluent-rs so that I can merge it into my branch? |
|
Yup, moved to here: zbraniecki#1 |
Added docs for FluentBundle. Also, corrected some errors in the pre-existing docs.