Skip to content

Add unicode escaping in resolver #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2019

Conversation

zbraniecki
Copy link
Collaborator

Fixes #79

@zbraniecki zbraniecki requested a review from stasm January 27, 2019 00:04
@zbraniecki zbraniecki force-pushed the unescape branch 2 times, most recently from 19c8107 to 7bfb9a1 Compare January 27, 2019 20:40
Copy link
Contributor

@stasm stasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I think I'd prefer unescape_unicode to always return a new String rather than Option<String>.

@zbraniecki
Copy link
Collaborator Author

@bjorn3 - I updated the code to use Cow. I kept the Option<String> internally to determine if the owned string has been initialized, but I return the Cow now. The performance remains the same while the ergonomics improved!

Do you want to take a look at the result to verify that it works as you imagined?

@zbraniecki zbraniecki merged commit ff5b216 into projectfluent:master Feb 1, 2019
@zbraniecki zbraniecki deleted the unescape branch February 1, 2019 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants