-
Notifications
You must be signed in to change notification settings - Fork 79
Throw on bundle.formatPattern if errors would be swallowed #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Do you think we should:
|
... or ...
I'd not do 1, I didn't think about 2. |
I'd vote for option 3. At that point, no matter what the specific error, showing some fallback string like the message key in the UI is probably at least pretty close to the least wrong thing to do, while printing the error in the console. If the library user wants to do something more complicated than that, that's exactly what the |
Fixed in #396 on the release branch. |
bundle.format
and soon,bundle.formatPattern
swallow errors if you don't pass in an errors array.We should throw on errors instead, I think.
The text was updated successfully, but these errors were encountered: