Skip to content

@fluent/react: stop using componentWillReceiveProps() #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rlr opened this issue Aug 21, 2019 · 2 comments
Closed

@fluent/react: stop using componentWillReceiveProps() #425

rlr opened this issue Aug 21, 2019 · 2 comments

Comments

@rlr
Copy link

rlr commented Aug 21, 2019

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: LocalizationProvider
spacemeowx2 added a commit to spacemeowx2/fluent.js that referenced this issue Dec 11, 2019
@stasm
Copy link
Contributor

stasm commented Dec 11, 2019

This will be fixed by #406.

@stasm
Copy link
Contributor

stasm commented Jan 14, 2020

#406 landed last week. Closing.

@stasm stasm closed this as completed Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants