Inline Patterns may start with any character. #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`}`, `.`, `*` and `[` are only special when they appear at the beginning of indented Pattern lines. When a Pattern starts on the same line as `id =` or `[variant key]`, its first character doesn't carry any special meaning and it may be one of those four ones as well.
stasm
force-pushed
the
inline-pattern-any-char
branch
from
5422f5b to
ecaebe5
Compare
Pike
approved these changes
Feb 8, 2018
There was a problem hiding this comment.
Can you also reference https://bugzilla.mozilla.org/show_bug.cgi?id=1436683 in the commit message?
Apart from that, r=me.
stasm
added a commit
to projectfluent/python-fluent
that referenced
this pull request
Feb 8, 2018
`}`, `.`, `*` and `[` are only special when they appear at the beginning of indented Pattern lines. When a Pattern starts on the same line as `id =` or `[variant key]`, its first character doesn't carry any special meaning and it may be one of those four ones as well. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1436685. Port of projectfluent/fluent.js#150.
stasm
added a commit
to stasm/fluent.js
that referenced
this pull request
Feb 8, 2018
- Correctly parse empty comment lines. (projectfluent#149) - Forbid null attribute and variant values. (part of projectfluent#150)
eemeli
pushed a commit
to mozilla/fluent-migrate
that referenced
this pull request
May 16, 2023
`}`, `.`, `*` and `[` are only special when they appear at the beginning of indented Pattern lines. When a Pattern starts on the same line as `id =` or `[variant key]`, its first character doesn't carry any special meaning and it may be one of those four ones as well. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1436685. Port of projectfluent/fluent.js#150. committer: GitHub <[email protected]>
jfx2006
pushed a commit
to jfx2006/tb-fluent-migrate
that referenced
this pull request
Jul 27, 2023
`}`, `.`, `*` and `[` are only special when they appear at the beginning of indented Pattern lines. When a Pattern starts on the same line as `id =` or `[variant key]`, its first character doesn't carry any special meaning and it may be one of those four ones as well. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1436685. Port of projectfluent/fluent.js#150. committer: GitHub <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
},.,*and[are only special when they appear at the beginning of indented Pattern lines. When a Pattern starts on the same line asid =or[variant key], its first character doesn't carry any special meaning and it may be one of those four ones as well.