Trim trailing whitespace in TextElements #247
Conversation
stasm
force-pushed
the
trim-trailing-whitespace
branch
from
5d4719e to
20cfdae
Compare
| # < whitespace > | ||
| key1 = Value | ||
|
|
||
| key2 = Value {placeable}. |
There was a problem hiding this comment.
I guess you didn't mean to have the trailing . here?
There was a problem hiding this comment.
Doch doch. I only meant to test that TextElements not in the last position are not affected by the trimming logic.
Ah, I see what you mean. Let me see.
It's only available in Firefox 61+ and Chrome 66+, and not in node. I don't want to get bitten by its being missing in a |
| // non-empty line will decide what to do with it. | ||
| const firstLineContent = start !== eol | ||
| // Trim the trailing whitespace in case this is a single-line pattern. | ||
| // Multiline patterns are parsed anew by getComplexPattern. |
There was a problem hiding this comment.
It would be nice to one day be able to pass first line to complex string and go from there.
There was a problem hiding this comment.
It's doable, but keep in mind that we'd need to parse firstLineContent in getComplexPattern anyways in case it contains placeables or escape sequences. The current approach of rewinding the index to the beginning of the first line works pretty well IMO.
No description provided.