Fix a couple AST mistakes caught while porting the parser to Rust

fluent-syntax/src/errors.js

@@ -23,7 +23,7 @@ function getErrorMessage(code, args) {
     }
     case 'E0005': {
       const [id] = args;
-      return `Expected entry "${id}" to have a value, attributes or tags`;
+      return `Expected entry "${id}" to have a value or attributes`;
     }
     case 'E0006': {
       const [field] = args;

fluent-syntax/src/ftlstream.js

@@ -226,7 +226,7 @@ export class FTLParserStream extends ParserStream {
       this.next();
       return ret;
     }
-    throw new ParseError('E0004', 'a-zA-Z');
+    throw new ParseError('E0004', 'a-zA-Z_');
   }
 
   takeIDChar() {
@@ -243,15 +243,11 @@ export class FTLParserStream extends ParserStream {
 
   takeSymbChar() {
     const closure = ch => {
-      if (ch === undefined) {
-        return false;
-      }
-
       const cc = ch.charCodeAt(0);
       return ((cc >= 97 && cc <= 122) || // a-z
               (cc >= 65 && cc <= 90) || // A-Z
               (cc >= 48 && cc <= 57) || // 0-9
-               cc === 95 || cc === 45 || cc === 32);  // _-
+               cc === 95 || cc === 45 || cc === 32);  // _-<space>
     };
 
     return this.takeChar(closure);

fluent-syntax/src/parser.js

@@ -153,7 +153,7 @@ export default class FluentParser {
 
       ps.next();
 
-      if (ps.current() === '/') {
+      if (ps.currentIs('/')) {
         content += '\n';
         ps.next();
         ps.expectChar('/');
@@ -212,7 +212,7 @@ export default class FluentParser {
       tags = this.getTags(ps);
     }
 
-    if (pattern === undefined && attrs === undefined && tags === undefined) {
+    if (pattern === undefined && attrs === undefined) {
       throw new ParseError('E0005', id.name);
     }
 
@@ -566,7 +566,14 @@ export default class FluentParser {
 
       ps.expectChar(')');
 
-      return new AST.CallExpression(literal.id, args);
+      if (!/^[A-Z_-]+$/.test(literal.id.name)) {
+        throw new ParseError('E0008');
+      }
+
+      return new AST.CallExpression(
+        new AST.Function(literal.id.name),
+        args
+      );
     }
 
     return literal;

fluent-syntax/test/fixtures_behavior/attribute_expression_with_wrong_attr.ftl

@@ -1,7 +1,7 @@
 key = { foo.23 }
 
-//~ ERROR E0004, pos 12, args "a-zA-Z"
+//~ ERROR E0004, pos 12, args "a-zA-Z_"
 
 key = { foo. }
 
-//~ ERROR E0004, pos 31, args "a-zA-Z"
+//~ ERROR E0004, pos 31, args "a-zA-Z_"

fluent-syntax/test/fixtures_behavior/call_expression_with_bad_id.ftl

@@ -0,0 +1,3 @@
+key = { no-caps-name() }
+
+//~ ERROR E0008, pos 22

fluent-syntax/test/fixtures_behavior/non_id_attribute_name.ftl

@@ -1,3 +1,3 @@
 key = Value
     .2 = Foo
-//~ ERROR E0004, pos 17, args "a-zA-Z"
+//~ ERROR E0004, pos 17, args "a-zA-Z_"

fluent-syntax/test/fixtures_behavior/unclosed_empty_placeable_error.ftl

@@ -1,2 +1,2 @@
 bar = Bar {
-//~ ERROR E0004, pos 11, args "a-zA-Z"
+//~ ERROR E0004, pos 11, args "a-zA-Z_"

fluent-syntax/test/fixtures_behavior/variant_ends_abruptly.ftl

@@ -1,3 +1,3 @@
 key = { $foo ->
     *[
-//~ ERROR E0004, pos 22, args "a-zA-Z"
+//~ ERROR E0004, pos 22, args "a-zA-Z_"

fluent-syntax/test/fixtures_behavior/variant_expression_empty_key.ftl

@@ -1,2 +1,2 @@
 key = { foo[] }
-//~ ERROR E0004, pos 12, args "a-zA-Z"
+//~ ERROR E0004, pos 12, args "a-zA-Z_"

fluent-syntax/test/fixtures_behavior/variant_starts_from_nl.ftl

@@ -1,4 +1,4 @@
 key = {
 *[one] Value
     }
-//~ ERROR E0004, pos 7, args "a-zA-Z"
+//~ ERROR E0004, pos 7, args "a-zA-Z_"

fluent-syntax/test/fixtures_behavior/variant_with_leading_space_in_name.ftl

@@ -1,4 +1,4 @@
 key = {
         *[  one] Foo
     }
-//~ ERROR E0004, pos 18, args "a-zA-Z"
+//~ ERROR E0004, pos 18, args "a-zA-Z_"