(@fluent/gecko) Prune obsolete build targets #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pike
reviewed
Apr 9, 2020
There was a problem hiding this comment.
So, Localization.jsm still claims that we're building it from here. It's also exempt from linting in m-c based on that ;-).
We should probably file a Core::Intl bug to clean that up?
I don't have huge concerns over this, but I'll leave the actual review to Zibi. Left a couple of nits on the makefile changes, I didn't test that.
|
@zbraniecki Would you mind taking a quick look at this? It's just some removals that I'd like you to be aware of. Thanks. |
zbraniecki
approved these changes
Apr 15, 2020
|
lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only the following targets are still used in Gecko:
FluentSyntax.jsmis used in tests,fluent-react.jsis used in Devtools.I wondered about
Fluent.jsm-- it's still used on the release channel in Firefox 75 today. If there's a any problem with it in the nex few weeks, I'll bring theFluent.jsmtarget back.