-
Notifications
You must be signed in to change notification settings - Fork 80
Add npm workspaces & tool-specific config files, drop make #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
6582225
d996498
11ea957
86f6ce3
b7bf2e8
0b27f66
e6f8b57
3221fcb
27c9165
c50e90d
2e8bdcf
e0d2335
8262a01
2ded43e
c09e7aa
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,25 @@ | ||
name: "@fluent/dom" | ||
name: legacy | ||
on: | ||
push: | ||
branches: [master] | ||
pull_request: | ||
branches: [master] | ||
workflow_dispatch: | ||
jobs: | ||
dist: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
node: [12.x, 14.x, 16.x] | ||
node: [12.x, 14.x] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question (blocking): How are you manually testing the CI changes. I'd like to ensure this works before it's merged in. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I ran the tests here: https://github.com/eemeli/fluent.js/actions I also added |
||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Use Node.js ${{matrix.node}} | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{matrix.node}} | ||
- name: Install build tools | ||
run: npm ci | ||
- name: Install package dependencies | ||
working-directory: ./fluent-dom | ||
run: npm ci | ||
- name: make dist | ||
working-directory: ./fluent-dom | ||
run: make dist | ||
- run: npm install --global npm@7 | ||
- run: npm ci | ||
- run: npm run build --workspaces | ||
- run: npm test | ||
- run: npm run lint | ||
- run: npm run docs --workspaces |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,24 @@ | ||
name: "@fluent/react" | ||
name: test | ||
on: | ||
push: | ||
branches: [master] | ||
pull_request: | ||
branches: [master] | ||
workflow_dispatch: | ||
jobs: | ||
dist: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
node: [12.x, 14.x, 16.x] | ||
node: [16.x] | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Use Node.js ${{matrix.node}} | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{matrix.node}} | ||
- name: Install build tools | ||
run: npm ci | ||
- name: Install package dependencies | ||
working-directory: ./fluent-react | ||
run: npm ci | ||
- name: make dist | ||
working-directory: ./fluent-react | ||
run: make dist | ||
- run: npm ci | ||
- run: npm run build --workspaces | ||
- run: npm test | ||
- run: npm run lint | ||
- run: npm run docs --workspaces |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
ignore: | ||
- fluent-dom/** | ||
- fluent-react/** | ||
ui: tdd |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -74,26 +74,25 @@ Hacking on `fluent.js` is easy! To quickly get started clone the repo: | |
$ git clone https://github.com/projectfluent/fluent.js.git | ||
$ cd fluent.js | ||
|
||
You'll need at least Node.js 12 LTS. Older versions are not supported. | ||
You'll need at least **Node.js 12** and **npm v7**. | ||
Older versions are not supported. | ||
|
||
Install the build tools used by all packages (Babel, Rollup, Mocha etc.): | ||
Install the dependencies used by all packages, which are managed as | ||
[npm workspaces](https://docs.npmjs.com/cli/v7/using-npm/workspaces): | ||
|
||
$ npm install | ||
|
||
Install dependencies of individual `fluent.js` packages which are required for | ||
passing tests: | ||
Build and test all packages at once: | ||
|
||
$ make deps | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. praise: Thanks, this nicer not have to deal with make for installing dependencies. |
||
|
||
Build all packages at once: | ||
|
||
$ make | ||
$ npm run dist | ||
|
||
…which is equivalent to: | ||
|
||
$ make lint | ||
$ make test | ||
$ make build | ||
$ npm run clean | ||
$ npm run build --workspaces | ||
$ npm run lint | ||
$ npm run test | ||
$ npm run docs --workspaces | ||
|
||
You can also `cd` into a package's directory and issue the above `make` | ||
commands from there. Only this one package will be affected. | ||
Each package may also be built separately by running `npm run build` in | ||
its directory. |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"type": "module" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: It will help with maintenance to document why this is legacy, and maybe how to migrate it to not be legacy anymore.