Skip to content

Improve the TypeScript lint/intellisense experience #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 13, 2021

Conversation

eemeli
Copy link
Member

@eemeli eemeli commented Sep 13, 2021

This is a follow-up to #569, where some of the dev-env challenges were discussed with @gregtatum.

With these changes, the lint task is no longer dependent on build and intellisense works immediately for internal cross-package dependencies.

The dependency of test on build remains, and it's turning out to be more difficult without in-depth changes. Briefly, Mocha does not offer an out-of-the-box path aliasing as e.g. TypeScript's paths or Jest's moduleNameMapper. This means that something like a Babel plugin would need to be registered for tests, as well as ts-node for handling the TypeScript sources. Alternatively, all of the tests could be ported to Jest and/or TypeScript. That sounds like more work than it's worth at this time.

Copy link
Member

@gregtatum gregtatum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, everything seems to be working well on my end.

@eemeli eemeli merged commit 30afac9 into projectfluent:master Sep 13, 2021
@eemeli eemeli deleted the better-ts-deps branch September 13, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants