Skip to content

Make Messages and Functions be in the same namespace #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

stasm
Copy link
Contributor

@stasm stasm commented Nov 14, 2018

Forbid all uppercase ASCII identifiers for Messages and effectively make Messages and Functions co-exist in the same namespace.

## BEFORE

# FUNC is a FunctionReference
one = {FUNC()}
# FUNC is a MessageReference
two = {FUNC.attr}

With a single namespace for both Messages and Functions, two becomes a syntax error.

## AFTER

# FUNC is a FunctionReference
one = {FUNC()}
# FUNC is still a FunctionReference → Syntax Error
# (FunctionReference is not a valid `ref` of an `AttributeExpression`.)
two = {FUNC.attr}

@stasm stasm force-pushed the forbid-uppercase-messages branch from 65c7df1 to dce474a Compare November 14, 2018 11:10
@stasm stasm requested a review from Pike November 14, 2018 11:23
Copy link
Contributor

@Pike Pike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got around this on our call, right? This is WONTFIX, IIRC?

As this request is still open, adding here what made me raise concerns on our call: Changing the range of valid message IDs at this point is hard to be confident about.

@stasm
Copy link
Contributor Author

stasm commented Nov 19, 2018

Yep, this is a wontfix.

@stasm stasm closed this Nov 19, 2018
@stasm stasm deleted the forbid-uppercase-messages branch November 19, 2018 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants