Fix #5. Allow select-expression with an empty selector #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbraniecki
reviewed
Jan 30, 2017
| @@ -32,7 +32,7 @@ quoted-text ::= ([^{"] | '\{' | '\"')+ | |||
| block-text ::= NL __ '|' unquoted-pattern | |||
|
|
|||
| placeable ::= '{' __ expression __ '}' | |||
| expression ::= selector-expression | select-expression | |||
| expression ::= selector-expression | select-expression | variants-list | |||
There was a problem hiding this comment.
you need to add variant-list
There was a problem hiding this comment.
it's... right there. in the line you commented on.
There was a problem hiding this comment.
the reference to it is, but the definition is nowhere to be found. Did I miss something?
There was a problem hiding this comment.
ah :) it's defined in line 23; not part of this patch.
There was a problem hiding this comment.
somehow github hid it from me
zbraniecki
approved these changes
Jan 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.