Rename args to arguments #238
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fields of our AST nodes are usually spelled out as full words. The only exception being the
id
, which I think is common enough to almost function on its own as a word, andargs
. This PR renamesargs
toarguments
, to match other names such asattributes
,annotations
etc.For implementations, this has both upsides and downsides. In Python, we've seen how
args
is a special attribute ofException
which cannot be anything else than a tuple. In JavaScript,arguments
may not be used as a variable binding in the strict mode. This would make destructuring assignment, such as inlet {id, arguments} = refNode;
impossible. The workaround is to userefNode.arguments
directly, or to reassign the property:let {id, arguments: args} = refNode
.