Skip to content

tests don't work in py3.6 #21

@zbraniecki

Description

@zbraniecki

I spent a good 2 hours today trying to understand why my patch breaks tests.

The two things that made it really hard were:

  1. In py2.7 when json doesn't match expected the diff contains all u'foo' != 'foo' which is terribly misleading.
  2. py3.6 did not report any errors.

The combination of those two led me onto the path of trying to discover if I changed somehow encoding of the tests, because only py2.7 seemed to be affected.

If we can't fix (1), can we at least fix (2) please?

STR:

  1. Change any of the fixture_structure json files, for example span start or end.
  2. run tox -e py36

Current result:
No error reported

Expected result:
Error reported

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions