Skip to content

tests don't work in py3.6 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zbraniecki opened this issue Oct 6, 2017 · 1 comment
Closed

tests don't work in py3.6 #21

zbraniecki opened this issue Oct 6, 2017 · 1 comment

Comments

@zbraniecki
Copy link
Collaborator

I spent a good 2 hours today trying to understand why my patch breaks tests.

The two things that made it really hard were:

  1. In py2.7 when json doesn't match expected the diff contains all u'foo' != 'foo' which is terribly misleading.
  2. py3.6 did not report any errors.

The combination of those two led me onto the path of trying to discover if I changed somehow encoding of the tests, because only py2.7 seemed to be affected.

If we can't fix (1), can we at least fix (2) please?

STR:

  1. Change any of the fixture_structure json files, for example span start or end.
  2. run tox -e py36

Current result:
No error reported

Expected result:
Error reported

@Pike
Copy link
Contributor

Pike commented Oct 9, 2017

The problem is that py36 doesn't find any tests in either test_behaviour or test_structure, the meta foo in that test case isn't producing the right tests.

six can help, http://python-future.org/compatible_idioms.html#metaclasses

@zbraniecki zbraniecki changed the title tox doesn't test py3.6 tests don't work in py3.6 Oct 9, 2017
@stasm stasm closed this as completed in #22 Oct 11, 2017
stasm added a commit that referenced this issue Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants