You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I spent a good 2 hours today trying to understand why my patch breaks tests.
The two things that made it really hard were:
In py2.7 when json doesn't match expected the diff contains all u'foo' != 'foo' which is terribly misleading.
py3.6 did not report any errors.
The combination of those two led me onto the path of trying to discover if I changed somehow encoding of the tests, because only py2.7 seemed to be affected.
If we can't fix (1), can we at least fix (2) please?
STR:
Change any of the fixture_structure json files, for example span start or end.
run tox -e py36
Current result:
No error reported
Expected result:
Error reported
The text was updated successfully, but these errors were encountered:
The problem is that py36 doesn't find any tests in either test_behaviour or test_structure, the meta foo in that test case isn't producing the right tests.
I spent a good 2 hours today trying to understand why my patch breaks tests.
The two things that made it really hard were:
u'foo' != 'foo'
which is terribly misleading.The combination of those two led me onto the path of trying to discover if I changed somehow encoding of the tests, because only py2.7 seemed to be affected.
If we can't fix (1), can we at least fix (2) please?
STR:
Current result:
No error reported
Expected result:
Error reported
The text was updated successfully, but these errors were encountered: