Skip to content

Bug 1318960 - Migrate files only when their messages change #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stasm
Copy link
Contributor

@stasm stasm commented Nov 3, 2017

@stasm stasm requested a review from Pike November 3, 2017 17:54
Copy link
Contributor

@Pike Pike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical nit, real questions in the bug.

import codecs
import logging

try:
from itertools import zip_longest
except:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bare except ;-)

@stasm stasm force-pushed the 1318960-migrate-only-when-messages-change branch 2 times, most recently from 010664d to 5fa48b5 Compare November 7, 2017 15:54
@stasm stasm force-pushed the 1318960-migrate-only-when-messages-change branch from 5fa48b5 to d129da8 Compare November 7, 2017 23:33
@stasm stasm merged commit 9ec3db8 into projectfluent:master Nov 7, 2017
@stasm stasm deleted the 1318960-migrate-only-when-messages-change branch November 7, 2017 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants