Require compare-locales in fluent.migrate #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make compare-locales a hard requirement for running and testing fluent.migrate
which already largely depends on it anyways. This reduces the complexity of
imports as well as the burden of deciding if a TestCase depends on
compare-locales or not. It also makes it less probable to accidentally skip
migration tests with `python -m unittest discover`.
The following commands may be used to run tests:
- python setup.py test - Only syntax tests in tests/syntax will be run.
compare-locales is not required.
- python -m unittest discover - All tests will be run. If compare-locales is
missing, tests will error.
It's possible to run only syntax or only migrate tests by specifying the
starting director on the CLI:
python -m unittest discover -s tests/syntax
python -m unittest discover -s tests/migrate
- tox - Tox will create different envs one if which is py27-cl. It contains
compare-locales and is configured to run both tests/syntax and
tests/migrate tests. All other tests only run tests/syntax.
stasm
commented
Feb 7, 2018
| @@ -21,5 +21,6 @@ | |||
| package_data={ | |||
| 'fluent.migrate': ['cldr_data/*'] | |||
| }, | |||
| tests_require=['six'] | |||
| tests_require=['six'], | |||
There was a problem hiding this comment.
I tried adding compare-locales here but python setup.py test fails with version conflicts when it tries to install it. compare-locales requires fluent==0.4.4 while python-fluent's master is usually newer than that.
Pike
approved these changes
Feb 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make compare-locales a hard requirement for running and testing fluent.migrate which already largely depends on it anyways. This reduces the complexity of imports as well as the burden of deciding if a TestCase depends on compare-locales or not. It also makes it less probable to accidentally skip migration tests with
python -m unittest discover.The following commands may be used to run tests:
python setup.py test- Only syntax tests in tests/syntax will be run. compare-locales is not required.python -m unittest discover- All tests will be run. If compare-locales is missing, tests will error.It's possible to run only syntax or only migrate tests by specifying the starting director on the CLI:
tox- Tox will create different envs one if which is py27-cl. It contains compare-locales and is configured to run both tests/syntax and tests/migrate tests. All other tests only run tests/syntax.