Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MessageContext.format #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MessageContext.format #67
Changes from all commits
a540993
3059ec2
ea68596
97da936
5fd424b
f76c965
b280a9d
b5d0a2f
b78f33f
c77ff6f
89ef658
8d879ea
cef0734
5cb1066
a011eae
d38d932
fea2742
8c1b02a
84fca75
5f8d8ec
5c36e5c
0e30a76
fc7ad8b
0188bea
104da18
bbde8e5
e9c9e66
edf121b
874c999
87fc3c3
46dea8b
3f028ad
c5c5246
34bc74a
b42d5a4
7f6345a
9f77d70
712d0fb
46a6d48
fb91884
5f41120
05e3dbc
02044b5
4d2f711
9343548
49c8e3c
7a2780f
f77147c
eb4fa5e
09cdc9a
ab24993
7c914cf
4c5a0c0
313e9b7
38f7b3a
8c4120b
7311fc6
28d2a3d
e3dc515
34820d2
cb22168
7e7b907
f383425
b859efb
8d825c1
dc6406a
f0f719c
e2cb337
e59724e
3945ad4
084d7ce
a505be0
e44543c
b97f537
b600eb2
9d84579
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a side note for @stasm mostly, but every time I put a readers hat on I see this as a flaw that we place the id as a raw string. I'd love us to consider
{ name }
and{ $name }
here at least.