Skip to content

New namespace package layout #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 15, 2019

Conversation

spookylukey
Copy link
Collaborator

First stab at #79

@spookylukey
Copy link
Collaborator Author

Hmm, that's weird. I got exactly those failures first time I tried, turned out to be due to git 'fixing' up the whitespace in some of the files, since I have this in my global git config:

[core]
  whitespace=fix,-indent-with-non-tab,trailing-space,cr-at-eol

So, I then overrode that locally:

git config core.whitespace ''

and re did the 'git mv' commands. Now everything works locally, the tests pass. But not on Travis. So it seems that when I pushed, something else applied that same git whitespace config...

@spookylukey
Copy link
Collaborator Author

Hm, it seems that git is still actually rewriting the file when I do 'git mv', but on disk it just moves the existing file, so that what you have in the repo is different from what you have in your working directory. And it doesn't tell you that when you do git status. Nice...

Copy link
Contributor

@stasm stasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks so much @spookylukey for working on this! I only have one comment about the name of the distribution as it will be known on PyPI.

@@ -2,7 +2,7 @@

from setuptools import setup

setup(name='fluent',
setup(name='fluent_syntax',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to use _ here (or -; practically they're the same), but unfortunately fluent-bundle is already taken on PyPI. I see three paths forward:

  1. We go with fluent_syntax and find a different name for fluent_bundle in the same schema, e.g. fluent_runtime.
  2. We go with fluent_syntax and re-use the existing fluent package name for fluent_bundle.
  3. We use a different separator. According to PEP 426, periods are allowed, too. How about fluent.syntax here and fluent.bundle in Implement fluent.bundle namespace package #81?

Out of the three, I think I like the option no. 3 the most, but I'm open to other opinions.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Option 3 also looks good to me. My choice of _ was due to following the guidelines here - https://github.com/pypa/sample-namespace-packages/tree/master/pkgutil#practical-usage - but it sounds like a period could work too. We can try that - I'm concerned the combination with namespace packages might confuse something - and if there is a problem we can think again.

@stasm stasm merged commit ac428d7 into projectfluent:master Jan 15, 2019
@spookylukey spookylukey deleted the namespace_packages branch March 3, 2019 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants