-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Updates to descriptive project files. #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also... README is not included in this, because I am working on that in another branch. I wanted to push this through so it wouldn't hold up #136 |
So, I realized that I have errors. I am going to take this back for about 10 minutes-20 minutes and fix those. When I reassign to you, it means it is ready for reals. |
Can you squash the commits on this and resubmit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do have some tests now; probably should mention them here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that was already captured in the text. I don't want to oversell folks on our tests, because we are still lacking quite a bit.
Can you suggest a specific edit to the following?
Testing
--------
.. image:: https://coveralls.io/repos/projectmesa/mesa/badge.svg
:target: https://coveralls.io/r/projectmesa/mesa
We are continually working to improve our testing. At the moment, we've been testing features by implementing them in simple models. This is useful since it also expands the library of sample models.
* Changing from .md to .rst * Updating formating from md to rst * Combing CHANGES.md into HISTORY.rst * Making minor updates to CONTRIBUTING.rst
2a1fef7
to
1b41189
Compare
@dmasad good call on the squash. :-).... let me know what you were thinking specifically for the test and I will update. The squash is done. |
How about something like this: |
Ah... okay. Now, I see what you were looking for. I made a couple of updates to your text to make it easier to scan / break it up. Does what is below work for you? (Let me know if you want updates to my updates and I will add them.) We are continually working to improve our testing. At the moment, we've been testing features by implementing them in simple models. This is useful since it also expands the library of sample models. We also have several traditional unit tests in the tests/ folder. If you're changing previous Mesa features, please make sure of the following:
|
Looks good! On Sun, Jul 5, 2015 at 6:33 PM Jackie Kazil [email protected]
|
Pending tests, this is ready to go. .... pending tests.... hahahaha... these are all text updates, so the tests shouldn't be failing. |
Updates to descriptive project files.
This pull request does the following...
The change to .rst makes doc integration easier and seems to be more or a Python standard than .md.