Skip to content

Gather the grafana/jsonnet-libs before the panel query change #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2024
Merged

Gather the grafana/jsonnet-libs before the panel query change #94

merged 1 commit into from
Aug 30, 2024

Conversation

megian
Copy link
Contributor

@megian megian commented Jul 18, 2024 •
edited by DebakelOrakel
Loading

grafana/jsonnet-libs#1285

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@megian megian requested a review from a team as a code owner July 18, 2024 15:30
@megian megian marked this pull request as draft July 18, 2024 15:31
@megian megian mentioned this pull request Jul 18, 2024
Open
54nd20
54nd20 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@54nd20 54nd20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the workaround locally. Cluster catalog compiled successfully.

@DebakelOrakel DebakelOrakel force-pushed the mixin-utils-workaround branch from cc488ec to 857d327 Compare August 30, 2024 09:19
@DebakelOrakel DebakelOrakel marked this pull request as ready for review August 30, 2024 09:19
@DebakelOrakel DebakelOrakel added the bug Something isn't working label Aug 30, 2024
@DebakelOrakel DebakelOrakel force-pushed the mixin-utils-workaround branch from 857d327 to 970b97b Compare August 30, 2024 09:34
@DebakelOrakel DebakelOrakel merged commit 68df4a1 into master Aug 30, 2024
45 checks passed
@DebakelOrakel DebakelOrakel deleted the mixin-utils-workaround branch August 30, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@54nd20 54nd20 54nd20 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@megian @54nd20 @DebakelOrakel