-
Notifications
You must be signed in to change notification settings - Fork 1.2k
darwin: Building with CGO produces warning #1660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is a bit annoying because everyone who develops on Mac on binaries that import client_golang have this warning (by default e.g. on Goland CGO is enabled) 🤔 e.g. when running tests. |
Unfortunately, they don't provide a replacement header with a couple of constants that are used, and I'm not aware of any
The first is probably the easiest, and probably my preference (and add a The second seems too broad. The third is a possibility, because as mentioned in the commit comment and the code, I've never seen the adjustment amount be non-zero. But if there's a case that could happen, we wouldn't report the same value as What do you think? |
process_collector: avoid a compiler warning on macOS (fixes #1660)
…s#1660) The header has a warning when included, with no way to shut it off, and no alternative to obtain these symbols. They're technically architecture specific values, but they aren't different between amd64 and arm64, so combine the definitions. Signed-off-by: Matt Harbison <[email protected]>
…s#1660) The header has a warning when included, with no way to shut it off, and no alternative to obtain these symbols. They're technically architecture specific values, but they aren't different between amd64 and arm64, so combine the definitions. Signed-off-by: Matt Harbison <[email protected]> Signed-off-by: Eugene <[email protected]>
…s#1660) The header has a warning when included, with no way to shut it off, and no alternative to obtain these symbols. They're technically architecture specific values, but they aren't different between amd64 and arm64, so combine the definitions. Signed-off-by: Matt Harbison <[email protected]>
This is on the latest client_golang (main) version, likely after #1616
Does not look serious, but something to fix cc @mharbison72
The text was updated successfully, but these errors were encountered: