Skip to content

promhttp handlers panic with "metric partitioned with non-supported labels" when providing a ConstLabel #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bracki opened this issue May 9, 2017 · 2 comments
Closed

promhttp handlers panic with "metric partitioned with non-supported labels" when providing a ConstLabel #299

bracki opened this issue May 9, 2017 · 2 comments
Assignees
@beorn7
Labels
bug

Comments

@bracki
Copy link

bracki commented May 9, 2017

The example for the promhttp handlers mention adding a ConstLabel {"handler": "some_handler"}.
When you do this, checkLabels will panic. I think it would make sense to not look at the ConstLabel when checking for labels. Otherwise you have to encode the handler name into the metric names to get sensible metrics for your handlers.
@beorn7 beorn7 self-assigned this May 9, 2017
@beorn7
Copy link
Member

beorn7 commented May 9, 2017

Oops, yeah, our hacky check for labels doesn't handle the recommended ConstLabels properly.

Will have to improve...

@beorn7 beorn7 added the bug label May 9, 2017
@beorn7 beorn7 mentioned this issue May 9, 2017
Merged
beorn7 pushed a commit that referenced this issue May 10, 2017
Improve promhttp tests
753a259 
- Use local registry to avoid conflicts between tests.
- Expose #299 by
  using ConstLabels in a test.
- Improve example: Buckets and help string must be consistent, even
  if the former is not enforced as of now, but see
  #222
@beorn7 beorn7 mentioned this issue May 10, 2017
Merged
@beorn7
Copy link
Member

beorn7 commented May 11, 2017

It should now work as expected.

Cori1109 added a commit to Cori1109/client_golang that referenced this issue Jan 9, 2023
@Cori1109
Improve promhttp tests
a9dae75 
- Use local registry to avoid conflicts between tests.
- Expose prometheus/client_golang#299 by
  using ConstLabels in a test.
- Improve example: Buckets and help string must be consistent, even
  if the former is not enforced as of now, but see
  prometheus/client_golang#222
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beorn7 beorn7

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bracki @beorn7