feat(prometheus): explicit label/metric name validation scheme #1822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
aknuds1
reviewed
Jun 30, 2025
| @@ -95,7 +95,7 @@ func (v2) NewDesc(fqName, help string, variableLabels ConstrainableLabels, const | |||
| help: help, | |||
| variableLabels: variableLabels.compile(), | |||
| } | |||
| if !model.IsValidMetricName(model.LabelValue(fqName)) { | |||
| if !model.IsValidMetricName(model.LabelValue(fqName), model.UTF8Validation) { | |||
There was a problem hiding this comment.
Why are you hard coding model.UTF8Validation here?
There was a problem hiding this comment.
NewDesc is controlled by us, e.g. we never call it with a customer's metric name. Changing the function signature touches 94 places in Mimir.
There was a problem hiding this comment.
@juliusmh client_golang isn't just used by Mimir though. Also, hard coding the name validation scheme here is a backwards incompatible change, albeit implicit. I personally think that either the validation scheme should be an explicit argument, or alternatively NewDesc could take variadic options and default to model.UTF8Validation (this would also be backwards incompatible, but at least we avoid hard coding). @ywwg What's your take?
juliusmh
force-pushed
the
remove_global_name_validation
branch
2 times, most recently
from
5a063ae to
8972161
Compare
juliusmh
force-pushed
the
remove_global_name_validation
branch
from
8972161 to
f427c16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.