Skip to content

Include Host Root CAs in Docker Mode #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2020
Merged

Include Host Root CAs in Docker Mode #41

merged 1 commit into from
Nov 4, 2020

Conversation

jayclassless
Copy link
Contributor

  • Loads the root CAs from the host system into the develop container.
  • Sets environment variables for node and requests to make sure they use the container's configured roots.

xi-prometheus
xi-prometheus approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@xi-prometheus xi-prometheus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, both on Linux and IQVIA Mac.

@jayclassless jayclassless merged commit 6679967 into baseline/master Nov 4, 2020
@jayclassless jayclassless deleted the baseline/use-host-roots branch November 4, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xi-prometheus xi-prometheus xi-prometheus approved these changes

@andreypopp andreypopp Awaiting requested review from andreypopp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayclassless @xi-prometheus