Skip to content

Additional 4.0.0 release preparations #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,13 @@ jobs:
- os: windows-2022
cpu: x64_x86_windows
bazel_target: dist_zip
# disabling Mac OS releases for now since they are working through existing build process
# - os: macos-11
# cpu: darwin_arm64
# - os: macos-11
# cpu: darwin_x86_64
- os: macos-14
cpu: darwin_arm64
bazel_target: dist_zip
- os: macos-13
cpu: darwin_x86_64
bazel_target: dist_zip


steps:
- uses: actions/checkout@v4
Expand Down
12 changes: 12 additions & 0 deletions BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,24 @@ config_setting(
values = {"cpu": "k8"},
)

config_setting(
name = "darwin_arm64",
values = {"cpu": "darwin_arm64"},
)

config_setting(
name = "darwin_x86_64",
values = {"cpu": "darwin_x86_64"},
)

package_naming(
name = "protobuf_javascript_pkg_naming",
platform = select({
":k8": "linux-x86_64", # currently the only supported build type in Github Actions
":x64_x86_windows": "win32",
":x64_windows": "win64",
":darwin_arm64": "osx-aarch_64",
":darwin_x86_64": "osx-x86_64",
"//conditions:default": "" # continues with current behavior when no --cpu is specified allowing existing internal builds to function
})
)
Expand Down
6 changes: 3 additions & 3 deletions MODULE.bazel
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module(name = "protobuf_javascript", version = "3.21.4")
module(name = "protobuf_javascript", version = "4.0.0")

bazel_dep(name = "protobuf", version = "31.1", repo_name = "com_google_protobuf")
bazel_dep(name = "protobuf", version = "32.0", repo_name = "com_google_protobuf")
bazel_dep(name = "rules_pkg", version = "1.0.1")
bazel_dep(name = "abseil-cpp", version = "20250127.0")
bazel_dep(name = "abseil-cpp", version = "20250512.1")
56 changes: 48 additions & 8 deletions MODULE.bazel.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.