Skip to content

Standby mode metric #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Standby mode metric #189

wants to merge 5 commits into from

Conversation

rmontenegroo
Copy link
Contributor

Hi!

I just added the host standbyMode metric. Not a big change at all.

https://code.vmware.com/apis/196/vsphere/doc/vim.HostSystem.StandbyMode.html

@pryorda
Copy link
Owner

pryorda commented Apr 15, 2020

@rmontenegroo Hello and Thank you for the PR! This all looks good but is there any way we could get a test for this metric?

@rmontenegroo
Copy link
Contributor Author

Sure! Trying to follow your CI script test. Using python 3.6.9 here but I got

(python3.6) rodmonte@deadpool:~/develop/vmware_exporter$ pytest --cov=. -v tests/unit
Traceback (most recent call last):
  File "/home/rodmonte/develop/python3.6/bin/pytest", line 5, in <module>
    from pytest import main
  File "/home/rodmonte/develop/python3.6/lib/python3.6/site-packages/pytest.py", line 13, in <module>
    from _pytest.fixtures import fixture, yield_fixture
  File "/home/rodmonte/develop/python3.6/lib/python3.6/site-packages/_pytest/fixtures.py", line 839, in <module>
    class FixtureFunctionMarker(object):
  File "/home/rodmonte/develop/python3.6/lib/python3.6/site-packages/_pytest/fixtures.py", line 841, in FixtureFunctionMarker
    params = attr.ib(convert=attr.converters.optional(tuple))
TypeError: attrib() got an unexpected keyword argument 'convert'

right after pip installing requirements.
Any tip?

@Jc2k
Copy link
Collaborator

Jc2k commented Apr 15, 2020

Does this help? pytest-dev/pytest#5903

@rmontenegroo
Copy link
Contributor Author

@Jc2k Thanks for the tip!
I changed requirements-test.txt so as to get tests working here:

pytest_docker_tools==0.2.0
pytest==5.4.1
pytest-cov==2.8.1
pytest-twisted==1.12
codecov==2.0.15
flake8==3.6.0

@rmontenegroo rmontenegroo deleted the standby_mode_metric branch April 16, 2020 00:38
@rmontenegroo rmontenegroo restored the standby_mode_metric branch April 16, 2020 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants