Async Set Operations #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added async set operations.
Added null and empty values checks in set operations that receive an array of values.
Feature/async set operations
|
@NirAgai |
amitla
requested changes
Jul 6, 2020
| @@ -265,10 +266,18 @@ public static TResult Retry<TResult>(Func<TResult> func, int maxAttempts) | |||
| { | |||
| return RetryUtil.Retry(func, maxAttempts); | |||
| } | |||
| public async static Task<TResult> RetryAsync<TResult>(Func<Task<TResult>> func, int maxAttempts) | |||
There was a problem hiding this comment.
In cases where you have methods that can only return the task without await-ing it, please do. in this case, the method should look something like this:
public static Task<TResult> RetryAsync<TResult>(Func<Task<TResult>> func, int maxAttempts)
{
return RetryUtil.RetryAsync(func, maxAttempts);
}the responsibility to await moves to the caller (keep in mind that the caller would have awaited the result anyway) this way you have one less async-await state machine in your result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.