Skip to content

Give more detailed error message in the "can't happen" branch of satisfier() #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

njsmith
Copy link
Contributor

@njsmith njsmith commented Jul 5, 2021

Example:

thread 'main' panicked at 'internal error: entered unreachable code: while processing package trio: accum_term = 0.19 isn't a subset of incompat_term = 0.19.0, which means the last assignment should have been a decision, but instead it was a derivation. This shouldn't be possible! (Maybe your Version ordering is broken?)', /home/njs/src/pubgrub/src/internal/partial_solution.rs:411:17
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

Fixes: gh-102

Copy link
Member

@Eh2406 Eh2406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I hope this will make it easier for the next person that needs to debug this!
Can you Change your PR to merge with the dev branch?
Some of the contributors only have limited time to work on the project, so we give them 10 days to comment before merging.

@njsmith njsmith changed the base branch from release to dev July 6, 2021 07:59
Copy link
Member

@mpizenberg mpizenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your input! I hope this can help the next person in the same situation.

Eh2406 pushed a commit that referenced this pull request Jul 16, 2021
…f satisfier() (#103)

Example:

thread 'main' panicked at 'internal error: entered unreachable code: while processing package trio: accum_term = 0.19 isn't a subset of incompat_term = 0.19.0, which means the last assignment should have been a decision, but instead it was a derivation. This shouldn't be possible! (Maybe your Version ordering is broken?)', /home/njs/src/pubgrub/src/internal/partial_solution.rs:411:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Fixes: gh-102
Eh2406 pushed a commit that referenced this pull request Jul 16, 2021
Example:

thread 'main' panicked at 'internal error: entered unreachable code: while processing package trio: accum_term = 0.19 isn't a subset of incompat_term = 0.19.0, which means the last assignment should have been a decision, but instead it was a derivation. This shouldn't be possible! (Maybe your Version ordering is broken?)', /home/njs/src/pubgrub/src/internal/partial_solution.rs:411:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Fixes: gh-102
@Eh2406 Eh2406 closed this Jul 16, 2021
@Eh2406
Copy link
Member

Eh2406 commented Jul 16, 2021

I am sorry, I wanted to make CI / Commit messages follow project guidelines happy and have this to count as merged. I seam not to have succeeded. and I force pushed to your njsmith:release. What a mess. Sorry.

Thank you for the contribution!

@mpizenberg
Copy link
Member

I see @njsmith code in the dev branch so you merged it. But the website UI does not interpret it as such ...
I think next time we have PRs with only the commit messages failing it's ok since we can simply change the commit message when doing the squash merge. No need to try make it pass within the PR.

@Eh2406
Copy link
Member

Eh2406 commented Jul 16, 2021

Right! I forget that I can reword it during the squash! That would have bean the correct solution.

zanieb pushed a commit to astral-sh/pubgrub that referenced this pull request Nov 8, 2023
…-rs#103)

Example:

thread 'main' panicked at 'internal error: entered unreachable code: while processing package trio: accum_term = 0.19 isn't a subset of incompat_term = 0.19.0, which means the last assignment should have been a decision, but instead it was a derivation. This shouldn't be possible! (Maybe your Version ordering is broken?)', /home/njs/src/pubgrub/src/internal/partial_solution.rs:411:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Fixes: pubgrub-rsgh-102
This was referenced Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panics and infinite loops
3 participants