Remove examples/electron-remote placeholder - #8874
Open
pubkey wants to merge 1 commit into
Open
Conversation
The folder only contained a README pointing at the electron example. The actual example project was removed long ago because @electron/remote is deprecated. Also drops the now-dead eslint ignore entry for the folder. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KaGdXoAK3RnWfbMcdDomgy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Describe the problem you have without this PR
The folder
examples/electron-remoteno longer contains an example project. The actual project was removed because@electron/remoteis deprecated (see theRemoved the electron-remote example because @electron/remote is deprecated.line in the CHANGELOG), and only a placeholderREADME.mdwas left behind that points readers to the regular electron example.This PR deletes the placeholder folder and the now-dead ignore entry for it in
eslint.config.mjs.Link check
The folder was referenced in exactly two places:
eslint.config.mjs- ignore entry, removed in this PR.CHANGELOG.md- the historical entry that records the removal, kept as is.examples/README.mddoes not list it in its table, the docs do not link to it, and nothing in.github/,package.json, or the build scripts references it. The@electron/remotemention indocs-src/docs/electron-database.mdis about the npm module itself, not this folder, so it stays untouched.Todos
Generated by Claude Code