Upgrade AWS provider to v7 and remove deprecated BucketV2 classes #2192
Conversation
- Updated instances of aws.s3.BucketV2 to aws.s3.Bucket across multiple files to align with the latest Pulumi AWS SDK. - Adjusted related configurations and policies to ensure compatibility with the new bucket type. - Removed deprecated dependencies from go.mod and go.sum files. - Updated README files to reflect changes in resource types. - Introduced a script for PR-mode preview testing of changed Pulumi examples.
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades AWS provider across TypeScript examples from v6 to v7 and replaces deprecated S3 classes with their current equivalents. The changes ensure compatibility with the latest AWS provider version and remove usage of deprecated V2 S3 resources.
Key changes:
- Upgraded
@pulumi/awsdependency from v6.x to v7.0.0 across multiple package.json files - Replaced deprecated
BucketV2withBucketandBucketWebsiteConfigurationV2withBucketWebsiteConfigurationacross all language examples - Added new PR preview validation tooling with
make pr_previewtarget for testing changed examples
Reviewed Changes
Copilot reviewed 63 out of 64 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| webserver-yaml/Pulumi.yaml | Updated YAML config to use newer AMI patterns and correct S3 bucket type |
| testing-unit-ts/mocha/index.ts | Added preview runtime guards for AMI lookups |
| testing-unit-ts/mocha/bucket_pair.ts | Migrated BucketV2 to Bucket in component resource |
| testing-pac-ts/tests/package.json | Upgraded AWS provider dependency to v7.0.0 |
| testing-integration-py/resource_s3.py | Replaced BucketV2 with Bucket in Python example |
| secrets-provider/vault/index.ts | Added preview guards and migrated S3 bucket classes |
| secrets-provider/aws/index.ts | Added preview guards and migrated S3 bucket classes |
| aws-ts-static-website/index.ts | Added domain validation guards and migrated S3/Route53 resources |
| aws-ts-static-website/acl.ts | Updated function signature to use new bucket types |
| aws-py-static-website/main.py | Added domain validation and migrated S3 bucket classes |
| scripts/pr-preview-changed.sh | New PR validation script for testing changed examples |
| Multiple S3 examples | Migrated from BucketV2 to Bucket across TypeScript, Python, Go, F#, and C# |
| Makefile | Added pr_preview target for PR validation |
| README.md | Added documentation for PR preview validation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
These changes all look reasonable. (and kudos for adding the script to test just changes form your own branch!) Looks like there's some digital ocean tests failing, but that seems to be rot in the test environment for DO and completely unrelated to your changes.
|
@mjeffryes Do you have admin rights in this repo? Seems those DO tests are preventing me from merging. Someone with admin rights needs to override. Should we consider taking those tests out of the workflow until we have a chance to figure out why they're failing? |
|
I do have admin rights, but we don't get special privileges for merging. :) I think the right thing to do is to make a separate PR to disable those tests for now so they aren't blocking changes. |
Summary
BucketV2andBucketWebsiteConfigurationV2classes withBucketandBucketWebsiteConfigurationmake pr_previewtarget for validating example changes in PRsChanges
@pulumi/awsfrom v6.x to v7.0.0 in package.json filesFixes pulumi/docs#15749
🤖 Generated with Claude Code