(GH-269) Fix Workspace Symbol Provider #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
force-pushed
the
gh-269
branch
3 times, most recently
from
1ee6f92 to
f4069ad
Compare
Previously if nil was passed into the build_file_uri method it would raise an obtuse error. This commit instead returns nil of the path is nil, otherwise it attempts to build a URI for the path.
Previously the Workspace Symbol Provider was not outputting DataTypes and was unnecessarily output debuging information for Facts. This commit adds support for DataTypes and ignores Facts. This commit also updates typos in the code comments.
Previously the workspace detection would use the RootURI even if it was nil. This commit changes the detection to see if the RootURI key exists AND the value is not nil.
Previously the Workspace Symbols request was not tested as part of the acceptance suite. This commit adds a Workspace symbols request test and refactors the mock editor client to make it easier to be consumed during development.
Previously the reply_error method was removed which meant that when an invalid message was passed, it would crash the editor service. This commit re-adds the missing method.
|
@jpogran merge-y merge-y ? |
jpogran
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #269
Previously if nil was passed into the build_file_uri method it would raise an
obtuse error. This commit instead returns nil of the path is nil, otherwise
it attempts to build a URI for the path.
Previously the Workspace Symbol Provider was not outputting DataTypes and was
unnecessarily output debuging information for Facts. This commit adds support
for DataTypes and ignores Facts. This commit also updates typos in the code
comments.