-
Notifications
You must be signed in to change notification settings - Fork 87
(PE-36058) Updates for pe-bolt-server-runtime and pe-installer-runtime for Puppet 8 #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PE-36058) Updates for pe-bolt-server-runtime and pe-installer-runtime for Puppet 8 #666
Conversation
|
55eeff0
to
60c0bc6
Compare
|
60c0bc6
to
2956c6c
Compare
|
@@ -24,6 +24,7 @@ | |||
# When cross-compiling, we can't use the rubygems we just built. | |||
# Instead we use the host gem installation and override GEM_HOME. Yay? | |||
pkg.environment "GEM_HOME", settings[:gem_home] | |||
pkg.environment "GEM_PATH", settings[:gem_home] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you confirm this is actually needed. I thought I hacked this in diagnosing a compilation error that turned out to be something different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I didn't, I just assumed we needed it. I can remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out we need it or gems with native extensions might fail to compile.
2956c6c
to
e49c0b0
Compare
|
e49c0b0
to
01f4e6a
Compare
|
No description provided.