(PA-5430) Patch augeas C extension #667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriaXLi
force-pushed
the
PA-5430/patch_augeas_c_extension
branch
from
5558acd to
b23e114
Compare
AriaXLi
force-pushed
the
PA-5430/patch_augeas_c_extension
branch
from
b23e114 to
c036844
Compare
joshcooper
reviewed
May 16, 2023
This issue is very similar to PA-4844 (puppetlabs#620) except it affects augeas instead of selinux When puppet is run with Ruby 3.2, this warning is generated: `/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/augeas.rb:48: warning: undefining the allocator of T_DATA class Augeas` This commit patches the autogenerated augeas C extension so there is no warning for augeas
AriaXLi
force-pushed
the
PA-5430/patch_augeas_c_extension
branch
from
c036844 to
3b22df1
Compare
|
Without my changes the warning will pop up: With my changes the warning does not pop up: |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Successfully built agent-runtime-main with build targets from agent-runtime-main on vanagon-generic-builder: https://jenkins-platform.delivery.puppetlabs.net/view/vanagon-generic-builder/job/platform_vanagon-generic-builder_vanagon-packaging-ship-repos_generic-builder/1047/ |
joshcooper
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is very similar to PA-4844 (#620) except it affects augeas instead of selinux
When puppet is run with Ruby 3.2, this warning is generated:
/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/augeas.rb:48: warning: undefining the allocator of T_DATA class AugeasThis commit patches the autogenerated augeas C extension so there is no warning for augeas