Skip to content

(PE-36058) Only use ntlm gem fork in bolt-server 2023.y #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2023

Conversation

donoghuc
Copy link
Contributor

We only need the workaround for PE-36078 in main (due to openssl3 compatability issues). Only ship the forked version in bolt-server for 2023.y PE

@donoghuc donoghuc requested review from a team as code owners May 16, 2023 16:39
@github-actions
Copy link

⚠️ DISCLAIMER

This task is still experimental, it can be invoked locally provided that development dependencies are installed (bundle install --with development).

Ensure all your local changes are committed, then run bundle exec rake vanagon:component_diff -- [options].

Run the task with --help to see all available options. If you notice unexpected behavior or want to suggest improvements, ping #prod-puppet-agent on Slack.

Here is what your code changes would affect:

Project agent-runtime-main

Nothing is affected 😊

@@ -0,0 +1,20 @@
component 'rubygem-rubyntlm-fork' do |pkg, settings, platform|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File has a typo in the name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a tpyo? ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ʇʎdo

We only need the workaround for PE-36078 in main (due to openssl3 compatability issues). Only ship the forked version in bolt-server for 2023.y PE
@github-actions
Copy link

⚠️ DISCLAIMER

This task is still experimental, it can be invoked locally provided that development dependencies are installed (bundle install --with development).

Ensure all your local changes are committed, then run bundle exec rake vanagon:component_diff -- [options].

Run the task with --help to see all available options. If you notice unexpected behavior or want to suggest improvements, ping #prod-puppet-agent on Slack.

Here is what your code changes would affect:

Project agent-runtime-main

Nothing is affected 😊

@nmburgan nmburgan merged commit b14bfcc into puppetlabs:master May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants