Add tests for -noarch #9318
Merged
Add tests for -noarch #9318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 3a54851 detected cases where the "architecture was in the title of a package and moves it to the end of the version string" such as ".86_64" But the noarch regex matched any occurrence "noarch", including "-noarch". That bug was fixed in commit ca36fc6. This commit adds some missing tests and refactors the regex.
|
This relates to #9085 |
mhashizume
approved these changes
Apr 11, 2024
|
Backport failed for Please cherry-pick the changes locally. git fetch origin 7.x
git worktree add -d .worktree/backport-9318-to-7.x origin/7.x
cd .worktree/backport-9318-to-7.x
git checkout -b backport-9318-to-7.x
ancref=$(git merge-base 47f7f3b507ce82d94569c74f5050954bbaded16c dc2850527309d42c7574b9afde20f0bee6cf1430)
git cherry-pick -x $ancref..dc2850527309d42c7574b9afde20f0bee6cf1430 |
I'm fairly confident this won't introduce a regression, but the "move it to the end of the string" behavior was a little surprising to me, so not sure... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 3a54851 detected cases where the "architecture was in the title of a package and moves it to the end of the version string" such as ".86_64" But the noarch regex matched any occurrence "noarch", including "-noarch". That bug was fixed in commit ca36fc6. This commit adds some missing tests and refactors the regex.