(bug) - Honour custom insync message in noop mode

[jordanbreen28]

Prior to this PR, a custom insync message was not honoured when applying a manifest in noop mode. This was later tracked down to the offending noop method found in the resource harness class, which did not call the change_to_s method to retrieve the custom insync message.

I've updated the method to match that of the sync method below, ensuring that the functionality of the custom isync provider feature is not any different whether running puppet in noop or no-noop mode.

Can see the two methods here

Additional Context

Have opted out of adding a space between (noop) and audit_message to match the three other implementations of this in the sync and noop methods.

[joshcooper]

Thanks @jordanbreen28 Is there a particular module we can use to demonstrate the issue?

[jordanbreen28]

hey @joshcooper this actually came through to us as a bug for the resource_api in this issue puppetlabs/puppet-resource_api#307. You can see in this comment that after a bit of playing around I was able to replicate this problem.

AFAIK there is no module I can think of that uses a custom insync message, I had to implement my own version of this example in a dsc module I had lying about in one of my environments open. puppetlabs-firewall firewallchain type includes the custom_insync feature and has an custom insync? method here in its provider, so it might be easier to take that module and update that method to return some custom message.

[joshcooper]

Thanks @jordanbreen28 Could you add a test for this case (should be in spec/unit/transaction/resource_harness_spec.rb) and rebase your PR to pick up some changes to fix Windows failures with 8.3 filenames?

[jordanbreen28]

@joshcooper sure! I'll try get some tests added shortly

[jordanbreen28]

hey @joshcooper, got a unit test added. Hope that suffices!

[joshcooper]

LGTM, could you squash your commits?

[jordanbreen28]

@joshcooper squashed 🙂 rubocop errors seem unrelated..

[joshcooper]

@jordanbreen28 rubocop released a new gem that flagged some buggy code in puppet. That's since been resolved. Can you rebase your PR against the main branch?

[jordanbreen28]

@joshcooper done!

[joshcooper]

jenkins please test this

[joshcooper]

jenkins please test this

[joshcooper]

jenkins please test this on redhat8-64

[joshcooper]

@jordanbreen28 could you push your PR to your fork of puppet?

[jordanbreen28]

@joshcooper done! Closing in favour of #9443