(CAT-1451) - Fixing nil check fix for SSL config #2473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praj1001
approved these changes
Sep 25, 2023
Ramesh7
requested review from
bastelfreak,
ekohl,
smortex and
a team
as code owners
Ramesh7
force-pushed
the
CAT-1451-erb-to-epp-regression
branch
from
2eeac05 to
230805d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While converting ERB to EPP the nil check evaluation got missed, so fixing the same.
Have taken this opportunity to check other recently converted files and haven't seen discrepancy, seems the above was miss.
Additional Context
Issue - #2472
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)