Remove mod_log_forensic from apache::default_mods (#2573) #2601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mod_log_forensic should not be included by default, as the module has security implications and might leak sensitive information from headers incl. passwords. Upstream documentation also warns about this: https://httpd.apache.org/docs/2.4/mod/mod_log_forensic.html#security
stdietrich
requested review from
bastelfreak,
ekohl,
smortex and
a team
as code owners
|
|
|
Wa added in stdietrich@0f06f1b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
mod_log_forensic should not be included by default, as the module has security implications and might leak sensitive information from headers incl. passwords.
Upstream documentation also warns about this:
https://httpd.apache.org/docs/2.4/mod/mod_log_forensic.html#security
Additional Context
The default installation through this module should be secure,
mod_log_forensicsweakens this.Related Issues (if any)
Fixes #2573
Checklist
puppet apply)