Skip to content

Conversation

b4ldr
Copy link

@b4ldr b4ldr commented Jan 11, 2021

This likley needs fixing in pdk or .sync but wanted to at least test the
fix first

This likely needs fixing in pdk or .sync but wanted to at least test the
fix first
@codecov-io
Copy link

codecov-io commented Jan 11, 2021

Codecov Report

Merging #260 (33ba906) into master (cada6d4) will increase coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
+ Coverage   72.96%   73.25%   +0.29%     
==========================================
  Files          17       17              
  Lines         773      774       +1     
==========================================
+ Hits          564      567       +3     
+ Misses        209      207       -2     
Impacted Files Coverage Δ
lib/facter/lvm_support.rb 77.14% <100.00%> (+0.67%) ⬆️
lib/facter/logical_volumes.rb 100.00% <0.00%> (+11.11%) ⬆️
lib/facter/physical_volumes.rb 100.00% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cada6d4...33ba906. Read the comment docs.

@b4ldr
Copy link
Author

b4ldr commented Jan 11, 2021

lvm_support spec test work with facter 3.11 all the others fact spec test work with facter 4 (and fail with facter 3). i can't see the difference that's triggering this

@CLAassistant
Copy link

CLAassistant commented Sep 1, 2021

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.25%. Comparing base (cada6d4) to head (33ba906).
⚠️ Report is 206 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
+ Coverage   72.96%   73.25%   +0.29%     
==========================================
  Files          17       17              
  Lines         773      774       +1     
==========================================
+ Hits          564      567       +3     
+ Misses        209      207       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@b4ldr b4ldr closed this Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants