Skip to content

Conversation

pmcmaw
Copy link
Contributor

@pmcmaw pmcmaw commented Jan 10, 2019

Removing the pin from bundler as the older version of bundler does not support newer version of ruby. Also updating testing to include puppet 6.

This PR is required to allow #270 to progress.

@pmcmaw pmcmaw force-pushed the bundler_failure_fix branch 4 times, most recently from 5b5716a to 62494ea Compare January 10, 2019 17:47
@codecov-io
Copy link

codecov-io commented Jan 10, 2019

Codecov Report

Merging #271 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
+ Coverage   44.37%   44.38%   +0.01%     
==========================================
  Files          11       11              
  Lines         773      775       +2     
==========================================
+ Hits          343      344       +1     
- Misses        430      431       +1
Impacted Files Coverage Δ
...puppetlabs_spec_helper/puppetlabs_spec/matchers.rb 20.83% <0%> (-0.45%) ⬇️
lib/puppetlabs_spec_helper/tasks/check_symlinks.rb 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b98af8...ce1d2d8. Read the comment docs.

@pmcmaw pmcmaw force-pushed the bundler_failure_fix branch from 62494ea to ce1d2d8 Compare January 10, 2019 17:55
@pmcmaw pmcmaw changed the title (WIP) - Resolving bundler ruby version failure (WIP) - Resolving bundler ruby version failure, updating tests to include puppet 6 Jan 10, 2019
@david22swan
Copy link
Member

Look's good to me, but you should probably get the opinion of someone who has worked more with the module.
+1

@pmcmaw pmcmaw changed the title (WIP) - Resolving bundler ruby version failure, updating tests to include puppet 6 (maint) - Resolving bundler ruby version failure, updating tests to include puppet 6 Jan 11, 2019
@HelenCampbell HelenCampbell merged commit 591d59e into puppetlabs:master Jan 11, 2019
@pmcmaw pmcmaw deleted the bundler_failure_fix branch January 11, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants