Kill fixes #114
Merged
Kill fixes #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An alternative would have been to rewrite the recovery stack on interrupt, filtering out catch items, and changing the behavior of enqueued bracket conditions. The implemented solution lets us do it "as we go" as part of normal evaluation, so we aren't paying any extra. |
garyb
approved these changes
Aug 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110
Fixes #113
This handles bracket/catch behavior with interrupts and finalizers by tagging each enqueued recovery item with the current interrupt status. When we go to evaluate them, we can check to see if the interrupt status has changed, and decide whether we should filter them out, or run the recovery.