Skip to content

document npm install #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alicebob opened this issue Mar 19, 2018 · 3 comments
Closed

document npm install #138

alicebob opened this issue Mar 19, 2018 · 3 comments

Comments

@alicebob
Copy link

alicebob commented Mar 19, 2018

When using this in a browser you need to run npm install react react-dom with specific react versions. Also pulp bundle isn't good enough anymore and you will need to use pulp browserify.
I did not find this documented anywhere (coming from the Thermite repo). It would be incredible helpful if that was mentioned in the README here and/or at Thermite.

See also
https://stackoverflow.com/questions/42763558/integrating-react-components-with-pux-where-does-require-come-from
https://stackoverflow.com/questions/43337332/electron-purescript-thermite

@ethul
Copy link
Contributor

ethul commented Mar 25, 2018

I agree that it would be helpful to mention that this module depends on the react library. Having an example of using NPM as one option to satisfy the dependency would be a nice addition to the README.

Thanks for bringing this up.

ethul added a commit that referenced this issue Apr 14, 2018
Resolves #96
Resolves #105
Resolves #138
Resolves #139
ethul added a commit that referenced this issue Apr 14, 2018
Resolves #96
Resolves #105
Resolves #138
Resolves #139
@alicebob
Copy link
Author

🎊 thanks!

@ethul
Copy link
Contributor

ethul commented Apr 15, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants