-
Notifications
You must be signed in to change notification settings - Fork 64
document npm install
#138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I agree that it would be helpful to mention that this module depends on the react library. Having an example of using NPM as one option to satisfy the dependency would be a nice addition to the README. Thanks for bringing this up. |
ethul
added a commit
that referenced
this issue
Apr 14, 2018
ethul
added a commit
that referenced
this issue
Apr 14, 2018
🎊 thanks! |
Welcome!
…On Sat, Apr 14, 2018 at 16:49 Harmen ***@***.***> wrote:
🎊 thanks!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#138 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVYy4sfTXNQheHZ3BH5nLDqjtVYNAfcks5tomDkgaJpZM4SxB8r>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
When using this in a browser you need to run
npm install react react-dom
with specific react versions. Alsopulp bundle
isn't good enough anymore and you will need to usepulp browserify
.I did not find this documented anywhere (coming from the Thermite repo). It would be incredible helpful if that was mentioned in the README here and/or at Thermite.
See also
https://stackoverflow.com/questions/42763558/integrating-react-components-with-pux-where-does-require-come-from
https://stackoverflow.com/questions/43337332/electron-purescript-thermite
The text was updated successfully, but these errors were encountered: