-
Notifications
You must be signed in to change notification settings - Fork 20
Remove Text.Parsing
module prefix
#78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
While we're at it we might as well update the module structure a bit. Since this is a very simple package I think it would make sense to have a single module act as the main API, reexporting from Combinators and CodePoints, similarly to purescript-strings (see https://github.com/purescript/purescript-strings/blob/master/src/Data/String.purs) |
@thomashoneyman What is the attitude towards these kind of changes in the PureScript ecosystem? Should we just do this the next time we push a breaking change? This would be the next release. |
@chtenb Core libraries avoid breaking changes, and so do particularly widely used contrib libraries (Aff, Argonaut), but otherwise it’s up to the maintainers to decide when a change is worth breaking things. When breaking things we generally try to make sure the upgrade path is well-described. This change is a simple find-replace so that’s easy — unless another package in the package set is using the same module names. Shuffling the modules around is a bigger change, so I hope we can still make it easy to migrate. I suppose that would just be changing all your imports to one single import though, so that’s easy enough. |
Is there a particular reason we don't use the Text namespace anymore by the way? Or put another way, do we have a formal set of guidelines about module names somewhere? |
To go along with purescript-contrib/purescript-parsing#147 -- this library could just as well do with just using
StringParser
as the module prefix, rather than includingText.Parsing
, as we don't follow the Haskell example of putting all text-related packages under aText
grouping.The text was updated successfully, but these errors were encountered: