Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use this library with
purerl
, but the use of FFI meant I'd have to maintain a fork. However, it turned out that all of the FFI logic could be done in PS, and I wouldn't have to maintain a fork!When writing the tests for
Data.URI.Common.match1From
, it seemed odd to me that it only matched at the exact index given rather than anything after that index. After converting the code, this seems like a bug. The first thing that happens is that the global flag is added to the regex. That seems like the intent is to match anything after the given index.The other possibility is that adding the global flag was the bug and this function could use a better name. I don't have any suggestions for a better name though.
In any case, it'd be great if the move away from using the FFI could be incorporated in this repo rather than my fork.
Feel free to squash this upon merge.