Skip to content

Allow parsing of hostnames that start with numbers #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Allow parsing of hostnames that start with numbers #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Data/URI/Host.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ derive instance genericHost ∷ Generic Host _
instance showHost ∷ Show Host where show = genericShow

parser ∷ Parser Host
parser = ipv6AddressParser <|> ipv4AddressParser <|> try regNameParser
parser = try ipv6AddressParser <|> try ipv4AddressParser <|> regNameParser

-- TODO: this is much too forgiving right now
ipv6AddressParser ∷ Parser Host
Expand Down
10 changes: 10 additions & 0 deletions test/Main.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,16 @@ main = runTest $ suite "Data.URI" do
Nothing)
Nothing
Nothing))
testIsoURIRef
"https://1a.example.com"
(Left
(URI
(Just (Scheme "https"))
(HierarchicalPart
(Just (Authority Nothing [(Tuple (NameAddress "1a.example.com") Nothing)]))
Nothing)
Nothing
Nothing))
testIsoURIRef
"http://en.wikipedia.org/wiki/URI_scheme"
(Left
Expand Down