Skip to content

(mk)onClose should fire on the "close" signal, not the "exit" signal #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Profpatsch opened this issue May 22, 2018 · 0 comments
Closed

(mk)onClose should fire on the "close" signal, not the "exit" signal #15

Profpatsch opened this issue May 22, 2018 · 0 comments

Comments

@Profpatsch
Copy link
Contributor

mkOnClose currently adds a callback for the "exit" signal, yet the node documentation clearly states that "close" “is distinct from the 'exit' event, since multiple processes might share the same stdio streams.”.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mkOnClose reacts to the 'close' signal instead of 'exit' Profpatsch/purescript-node-child-process
1 participant
@Profpatsch